Re: [PATCH 00/18] Make system artifact building happen in plugins
On Thu, Jul 26, 2012 at 01:02:52PM +0100, Daniel Silverstone wrote:
On Thu, Jul 26, 2012 at 12:13:22PM +0100, Lars Wirzenius wrote:
> Since Richard is away, and he's the one best qualified to review this,
> I'll merge it myself tonight or tomorrow, unless someone objects.
I'll try and read through it now, so that if I have any major niggles they can
be dealt with then.
I'm okay with you merging this for now.
However, a point for future consideration: Parameterising fstab creation in case
the device isn't providing /dev/sda1 or we need to build a non-btrfs disk image.
Also it'll be worthwhile breaking up the stages of the disk image creation a
tad more at that point. Again, some-future-time.
D.
--
Daniel Silverstone http://www.codethink.co.uk/
Senior Developer GPG 4096/R Key Id: 3CCE BABE 206C 3B69