[PATCH] Morph: hide "Install chunk foo" messages when building
by Lars Wirzenius
repo: git://git.baserock.org/baserock/baserock/morph
branch: liw/quieten-staging-area
commit: c1d73faab8d3a9ad50e76c57d41ccbf266a88048
land: master
card: none; this is a quick hack
I got tired of Morph writing out dozens of lines like this:
Installing chunk foo from cache cafebee
These message fly on the screen, most of the time, since the artifact
is already unpacked into to cache, and can be very quickly hardlinked
into the staging area. The messages were originally added to let the
user know that something slow is happening.
This patch reduces the message spam by making the "Installing
chunk..." message be turned off by default, and adding a new message
that is shown only when a chunk is actually unpacked.
Lars Wirzenius (1):
Reduce spam from setting up staging area
morphlib/buildcommand.py | 9 +++++----
morphlib/stagingarea.py | 5 ++++-
morphlib/stagingarea_tests.py | 2 +-
3 files changed, 10 insertions(+), 6 deletions(-)
--
1.8.5.3
9 years
Considering UX when reviewing
by Rob Taylor
Hi guys,
The recent change and following discussion got me thinking - given that
what we are trying to do here is make some tooling that is lovely to
use, we should be explicitly considering UX when reviewing patches, and
not just code level review.
I'm thinking maybe just a simple +1UX/-1UX type scheme would suffice.
Obviously any patch that ends up with a negative UX review would need
further work, no matter how awesome the code is..
Thoughts?
Rob
9 years
[PATCH 0/2] Morph: show useful error when attempting to build a cluster morph
by Sam Thursfield
Repository: git://git.baserock.org/baserock/baserock/morph
Ref: sam/build-cluster-error
Sha1: ff473bab72a3a42ceee228b739577a153a3840de
This is a drive-by fix, I've not got time for a better one. Previously
giving a cluster morphology to `morph deploy` gave the following:
# PYTHONPATH=/src/morph /src/morph/morph build test-cluster
2014-03-12 10:19:30 Starting build c7dac36a93674b35980af5965388e2b4
2014-03-12 10:19:30 Collecting morphologies involved in building test-cluster from master
2014-03-12 10:19:32 Building file:///src/ws2/master/baserock/baserock/definitions/g refs/heads/baserock/builds/cf538939d08b4a8b8be758b68972b425/79799ec3816b4b0da5f893d6d45eb594 test-cluster.morph
2014-03-12 10:19:32 Deciding on task order
2014-03-12 10:19:32 Updating cached git repository file:///src/ws2/master/baserock/baserock/definitions/g
Traceback (most recent call last):
File "/usr/lib/python2.7/site-packages/cliapp/app.py", line 190, in _run
self.process_args(args)
File "/src/morph/morphlib/app.py", line 258, in process_args
cliapp.Application.process_args(self, args)
File "/usr/lib/python2.7/site-packages/cliapp/app.py", line 539, in process_args
method(args[1:])
File "/src/morph/morphlib/plugins/build_plugin.py", line 158, in build
system_name])
File "/src/morph/morphlib/buildcommand.py", line 59, in build
srcpool = self.create_source_pool(repo_name, ref, filename)
File "/src/morp ch/morphlib/buildcommand.py", line 92, in create_source_pool
self.lrc, self.rrc, (repo_name, ref, filename))
File "/src/morph/morphlib/app.py", line 293, in create_source_pool
visit=add_to_pool)
File "/src/morph/morphlib/app.py", line 361, in traverse_morphs
visit(reponame, ref, filename, absref, tree, morphology)
File "/src/morph/morphlib/app.py", line 288, in add_to_pool
morphology, filename)
File "/src/morph/morphlib/source.py", line 53, in __init__
for name in self.split_rules.artifacts}
AttributeError: 'NoneType' object has no attribute 'artifacts'
It's an easy mistake to make (at least for me!) so we should show
a proper error. It now shows the following:
# PYTHONPATH=/src/morph /src/morph/morph build test-cluster
2014-03-12 12:04:38 Starting build c588b777b8774ae6842909adc78a406f
2014-03-12 12:04:38 Collecting morphologies involved in building test-cluster from master
2014-03-12 12:04:40 Building file:///src/ws2/master/baserock/baserock/definitions/g refs/heads/baserock/builds/cf538939d08b4a8b8be758b68972b425/79799ec3816b4b0da5f893d6d45eb594 test-cluster.morph
2014-03-12 12:04:40 Deciding on task order
2014-03-12 12:04:40 Updating cached git repository file:///src/ws2/master/
ERROR: Cannot build a morphology of type 'cluster'.
Sam Thursfield (2):
Fix creating a Source() from a cluster morphology
Give a useful error when attempting to build a cluster morph
morphlib/app.py | 5 ++++-
morphlib/artifactsplitrule.py | 2 +-
2 files changed, 5 insertions(+), 2 deletions(-)
--
1.8.5.3
9 years
Add rsync support to Gitano for Trove
by Daniel Silverstone
This three-series set of patches adds plugin support, programmable repository
detection and then rsync support to Gitano (the git server used by Trove)
The first two series make sense to upstream, and upstream they will go. The
third series (one patch really) adds the rsync plugin and at least for now that
is Trove specific and so should not go upstream.
The merging onto baserock/morph of everything is clean, but as of now, it has
not been tested against its use case of git-fat as used by morph.
I am looking for reviews to be done on the assumption that (a) it works fine in
its target use case and (b) that even with enough +1s, no merge will occur
until (a) is confirmed by a third party.
I have tested the behaviour with git-fat locally on my system and it worked
fine, which is what is giving me the confidence to request the above.
Each series builds on the previous series so if you wish to test, I suggest
merging the tip of the rsync series into your branch since that will pull the
rest in automatically.
Thanks,
Daniel.
9 years
Workspaces may need to be tweaked or re-created
by Lars Wirzenius
I have just pushed the changes to Morph to make ./check pass again. As
part of this work, I changed how Morph creates directories for git
repositories in system branches in the workspace. Specifically, when a
URL contains colons in the "network location" or "path" parts, they
get replaced with slashes.
Thus, given system branch master for baserock:baserock/definitions,
the git directory used to be:
master/baserock:baserock/definitions
Now it is instead:
master/baserock/baserock/definitions
Morph will mostly find checked out git directories with either name,
but the system branch root repository is an exception. To fix this:
* EASY: create a new workspace with the current morph.
* EASY2, but a bit more fiddling:
- mkdir master/baerock
- mv master/baserock:baserock master/baserock/baserock
- edit master/.morph-system-branch/config and fix the pathname for
the root= setting
--
http://www.codethink.co.uk/ http://wiki.baserock.org/ http://www.baserock.com/
9 years
[PATCH 0/3] Add support to build out-of-tree kernel modules.
by Pedro Alvarez
Repo: upstream:linux
Branch: baserock/pedroalvarez/kernel-modules2
Sha1: 0dcada4933d12416302f2ae7ef18847cffd2481e
Card: S10651
Changes required to be able to build out-of-tree
kernel modules.
Pedro Alvarez (3):
Convert the morphology to yaml
Install kernel headers.
Split the linux chunk in devel, bins, and libs artifacts.
linux.morph | 151 +++++++++++++++++++++++++++++++++--------------------------
1 file changed, 85 insertions(+), 66 deletions(-)
--
1.7.10.4
9 years
[PATCH] V2: Fix tests.deploy/deploy-cluster
by Sam Thursfield
Repository: git://git.baserock.org/baserock/baserock/morph
Ref: sam/deploy-test-fix
Sha1: bd3208b38f99d6fd95330c9aea6862d9dedbfc50
Previous version of this patch series was broken. Sorry for the noise.
Sam Thursfield (1):
tests: Fix tests.deploy/deploy-cluster
tests.deploy/deploy-cluster.script | 10 ++--------
tests.deploy/deploy-cluster.stdout | 2 ++
2 files changed, 4 insertions(+), 8 deletions(-)
create mode 100644 tests.deploy/deploy-cluster.stdout
--
1.8.5.3
9 years
